fix(aria-valid-attr-value): mark as needs review for aria-current with invalid value #1998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aria-current with an invalid value is just treated as "aria-current=true."
With another value needing to be marked as incomplete we needed to have different remediation messages for each one (aria-describedby for missing id and aria-current for invalid value). Because of this we couldn't return an array of values since we needed to set the
messageKey
property of the data.What this all means is that only one needs review item can be marked on an element at a time due to the need of different need review messages.
Closes issue: #1773
Reviewer checks
Required fields, to be filled out by PR reviewer(s)