fix(region-rule): allow live regions with explicit roles #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Awesome, thanks for the pr. LGTM, just want @WilcoFiers to take a look to make sure I didn't miss anything |
WilcoFiers
approved these changes
Jan 27, 2020
WilcoFiers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The region rule should always allow content in an ARIA live region. The current code fails the rule based on role before it gets to the
aria-livecheck. This fix moves that check up so a region withrole="alert"andaria-liveis allowed.Closes issue: #1992
Reviewer checks
Required fields, to be filled out by PR reviewer(s)