Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commons to be configurable #2184

Open
WilcoFiers opened this issue Apr 28, 2020 · 1 comment
Open

Allow commons to be configurable #2184

WilcoFiers opened this issue Apr 28, 2020 · 1 comment
Labels
commons Issues in the common code (lib/commons) configuration rules / checks customisation
Milestone

Comments

@WilcoFiers
Copy link
Contributor

There are quite a large number of defaults in axe.commons that are difficult to update, such as:

  • getRole(); are fallback roles supported
  • aria.lookupTable: what roles are available, and which ones are supported
  • isModalOpen(), what threshold size should this use
  • getScroll(), what error bars should be used

It is currently impossible to configure these, except if options are provided at a check level. It would be helpful if commons could be configured in the axe.run options object, or as part of axe.configure.

@WilcoFiers WilcoFiers added this to the Axe-core 4.0 milestone Apr 28, 2020
@WilcoFiers WilcoFiers added commons Issues in the common code (lib/commons) configuration rules / checks customisation labels May 4, 2020
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.0, axe-core 4.1 Jun 22, 2020
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.1, axe-core 4.2 Sep 9, 2020
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.2, axe-core 4.3 Jan 7, 2021
@WilcoFiers WilcoFiers modified the milestones: axe-core 4.3, Axe-core 4.4 May 12, 2021
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.4, Axe-core 4.5 Nov 10, 2021
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.5, Axe-core 4.6 May 19, 2022
@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.6, Axe-core 4.7 Nov 2, 2022
@straker
Copy link
Contributor

straker commented Jan 17, 2023

WIth the addition of supporting the inert attribute, we should allow the support of inert to be configurable as well.

@WilcoFiers WilcoFiers modified the milestones: Axe-core 4.8, Axe-core 4.9 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons Issues in the common code (lib/commons) configuration rules / checks customisation
Projects
None yet
Development

No branches or pull requests

2 participants