feat(commons/aria): deprecate getRole({ noImplicit }) for getExplicitRole() #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…semantic role function. deprecate noImplicit option from getRole.
WilcoFiers
previously requested changes
Jun 16, 2020
straker
changed the title
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #2281, one of the tests was failing because it wanted the explicit role but role conflict resolution was getting in the way and returning
null. So created a function to get just the explicit role with no conflict resolution and madegetRolethe semantic role function. Deprecated thenoImplicitoption ofgetRoleas that functionality is now covered bygetExplicitRole.Also made sure
getRolecould work with virtual nodes.Once this is merged, will pull it into #2281 to finish it off.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)