Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(standards): add dpub-roles spec #2332

Merged
merged 2 commits into from
Jun 30, 2020
Merged

feat(standards): add dpub-roles spec #2332

merged 2 commits into from
Jun 30, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Jun 29, 2020

I generating the list automatically using a custom script on the 1.0 spec page. I then created a script to diff the generated file against our current lookup table and modified the output as needed to match (putting comments where and why changes were made).

The final output of the diff contains things I believe we are OK with but am putting here for reference. They are mostly additional aria allowed attrs that the current lookup table did not have but the spec allows. Seems we missed 2 name from content roles and a single allowed attr.

====== doc-glossref.nameFromContent ======
* doc-glossref.nameFromContent does not exist in the lookupTable
{ AssertionError [ERR_ASSERTION]: doc-glossref.nameFromContent does not match
    at file:///Users/stevenlambert/deque/axe-core/diff.mjs:49:14
    at ModuleJob.run (internal/modules/esm/module_job.js:95:12)
  generatedMessage: false,
  name: 'AssertionError [ERR_ASSERTION]',
  code: 'ERR_ASSERTION',
  actual: true,
  expected: undefined,
  operator: 'deepEqual' }


====== doc-noteref.nameFromContent ======
* doc-noteref.nameFromContent does not exist in the lookupTable
{ AssertionError [ERR_ASSERTION]: doc-noteref.nameFromContent does not match
    at file:///Users/stevenlambert/deque/axe-core/diff.mjs:49:14
    at ModuleJob.run (internal/modules/esm/module_job.js:95:12)
  generatedMessage: false,
  name: 'AssertionError [ERR_ASSERTION]',
  code: 'ERR_ASSERTION',
  actual: true,
  expected: undefined,
  operator: 'deepEqual' }


====== doc-pagebreak.allowedAttrs ======
{ AssertionError [ERR_ASSERTION]: doc-pagebreak.allowedAttrs does not match
    at file:///Users/stevenlambert/deque/axe-core/diff.mjs:49:14
    at ModuleJob.run (internal/modules/esm/module_job.js:95:12)
  generatedMessage: false,
  name: 'AssertionError [ERR_ASSERTION]',
  code: 'ERR_ASSERTION',
  actual: [ 'aria-expanded', 'aria-orientation' ],
  expected: [ 'aria-expanded' ],
  operator: 'deepEqual' }

Part of issues: #2108, #2303, and #2243

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner June 29, 2020 22:33
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this .mjs?

Copy link
Contributor

@WilcoFiers WilcoFiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a ".mjs" file?

@straker
Copy link
Contributor Author

straker commented Jun 30, 2020

Ha. I didn't know how to load it as a js file using imports in my node script so had them as .mjs extensions so it would work. Forgot to name it back.

@straker straker dismissed stale reviews from WilcoFiers and stephenmathieson June 30, 2020 14:18

Resoled

Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File extension LGTM 😆

Please have someone else who has been following this "standards" work more closely review the rest of this PR tho.

@straker straker changed the title feat(standards): add dpub roles feat(standards): add dpub-roles spec Jun 30, 2020
@straker straker merged commit 7ec3185 into develop Jun 30, 2020
@straker straker deleted the standards-dpub-roles branch June 30, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants