Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commons/table/to-grid does not account for rowspan=0 #2553

Closed
straker opened this issue Oct 13, 2020 · 1 comment
Closed

commons/table/to-grid does not account for rowspan=0 #2553

straker opened this issue Oct 13, 2020 · 1 comment
Assignees
Labels
commons Issues in the common code (lib/commons) fix Bug fixes

Comments

@straker
Copy link
Contributor

straker commented Oct 13, 2020

Noticed this while working on #2545. According to MDN, rowspan=0 means the row spans to the end of the table (tested in Chrome).

if its value is set to 0, it extends until the end of the table section (<thead>, <tbody>, <tfoot>, even if implicitly defined), that the cell belongs to

Our get-headers code will also need to be adjusted to handle rospawn of 0.

@straker straker added fix Bug fixes commons Issues in the common code (lib/commons) labels Oct 13, 2020
@straker straker self-assigned this Dec 24, 2020
@padmavemulapati
Copy link

padmavemulapati commented Jan 6, 2021

Verified in the axe-core latest develop code:
with the code snippet:
<!-- rowspan=0 - headers-->
<table>
<tr><td rowspan="0"></td><th scope="col">1</th><th scope="col" id="t1">2</th></tr>
<tr><th scope="row" id="t2"></th><td id="target"></td></tr>
</table>
on chrome:

image

on firefox:
image

@straker straker closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commons Issues in the common code (lib/commons) fix Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants