fix(color-contrast): allow small text shadows to serve as text outline #2627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
changed the title
WilcoFiers
force-pushed
the
shadow-contrast
branch
from
2e6f9fd
to
1a6d783
Compare
WilcoFiers
commented
Nov 9, 2020
Comment on lines
-95
to
+118
| return 3.7 / (blurRadius + 8); | ||
| const relativeBlur = blurRadius / fontSize; | ||
| return 0.185 / (relativeBlur + 0.4); |
There was a problem hiding this comment.
In working through this I realised these numbers should be relative to the font-size. I used a 20px font when I got these numbers, so I divided the numbers by 20. Block 9 in the text-shadow integration tests handle this.
WilcoFiers
commented
Nov 9, 2020
Comment on lines
532
to
540
| /* | ||
| False positives: | ||
| - b5-r3-i1, b5-r3-i2 | ||
| - b7-r3-i1, b7-r3-i2 | ||
|
|
||
| False negatives: | ||
| - b3-r1-i1 | ||
| - b4-r1-i1, b4-r2-i1 | ||
| - b8-r1-i1, b8-r5-i1 |
There was a problem hiding this comment.
Left this here just to have a record of it. All these test cases are on the edge of pass and fail. If we ever revisit them, these are the ones I think could be improved on, but I suspect I've put enough time into this it'll never come up.
There was a problem hiding this comment.
Can you put this comment in the code? Otherwise in a month or two we won't remember what the comment in the code means (there's no context).
WilcoFiers
changed the title
straker
previously requested changes
Nov 9, 2020
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
straker
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #2541
Reviewer checks
Required fields, to be filled out by PR reviewer(s)