-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(skip-link): work with absolute and relative paths #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
previously requested changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small things.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
straker
changed the title
fix(skip-link): work with absoulte and relative paths
[WIP] fix(skip-link): work with absoulte and relative paths
Apr 30, 2021
Boone6969
previously approved these changes
Aug 14, 2021
WilcoFiers
changed the title
[WIP] fix(skip-link): work with absoulte and relative paths
fix(skip-link): work with absoulte and relative paths
Dec 14, 2021
straker
changed the title
fix(skip-link): work with absoulte and relative paths
[WIP] fix(skip-link): work with absoulte and relative paths
Jan 6, 2022
straker
changed the title
[WIP] fix(skip-link): work with absoulte and relative paths
fix(skip-link): work with absolute and relative paths
Jan 17, 2022
…-core into absolute-skip-link
WilcoFiers
reviewed
Jan 18, 2022
WilcoFiers
previously requested changes
Jan 19, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue: #2791