-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
svg-img-alt issue text in axe DevTools extension is misleading #3175
Comments
Thanks for the issue. Just need to update the rule metadata help text with the additional wording. |
Thank you for the feedback @goodwitch. This rule is written in an "expectation" style. This is the same way that WCAG requirements are written "Non-text content has an accessible text". The ACT rule which this is based on has a similar title "svg element with explicit role has non-empty accessible name". Unfortunately, axe-core has gotten a little inconsistent about whether to use requirement-style or expectation-style rule descriptions. I personal tend to favour expectation-style for a variety of reasons:
We'll discuss how to go about this. I can certainly see why expectation-style might be confusing, but I disagree that it's misleading. If anything, putting "must" in the description seems misleading. |
@WilcoFiers I'm pointing out that the SVG statement is different from all the others (and misleading). Let's see how the others in this screenshot all indicate what is rule has been broken...while the SVG statement acts like having an img role with alternative text is a wrong
So...the following short rule description is not structured like all the rest.
So...I'll be happy to remove the VERY from this title. But I stand behind that this is a misleading statement (and not in line with the way all the other short issue names are written). |
Product: axe DevTools Pro Extension
Actual/Problem
axe DevTools Pro throws a real issue about SVG missing alt, but the wording of the issues is VERY misleading.
Current issue text displayed in axe DevTools Pro: "svg elements with an img role have an alternative text"
Expectation:
When in reality...this should say: "svg elements with an img role MUST have an alternative text"
How to Recreate
This rule is https://dequeuniversity.com/rules/axe/4.3/svg-img-alt
You can see this problem in real life by
Motivation: Having an accurate issue short name will help users of axe DevTools Pro focus on fixing the problem...instead of confusing them.
axe-core version: 4.3.3
axe DevTools extension version: 4.17.1
Browser and Assistive Technology versions
For Tooling issues:
The text was updated successfully, but these errors were encountered: