Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configure): Deprecate branding: Object, use a string instead. #3278

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

WilcoFiers
Copy link
Contributor

Because the brand property is no longer in use, it is deprecated as of version 4.4. This makes it unnecessary to configure branding using an object, which now only has one property. So along with deprecating the brand property, the Branding object is also deprecated. Use a string instead:

// previously
axe.configure({
  branding: { application: 'axe-playwright' }
})
// current
axe.configure({ branding: 'axe-playwright' })

Closes issue: #2891

@WilcoFiers WilcoFiers requested a review from a team as a code owner November 12, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants