fix(listitem): allow li as child of menu #3286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
changed the title
dylanb
reviewed
Nov 17, 2021
| }); | ||
|
|
||
| it('should fail if the listitem has an incorrect parent', function() { | ||
| fixture.innerHTML = '<div><li id="target">My list item</li></div>'; |
There was a problem hiding this comment.
this sort of change makes reviewing just the actual changes tedious
dylanb
previously approved these changes
Nov 17, 2021
|
tests |
WilcoFiers
force-pushed
the
menu-li-fix-3284
branch
from
1d42ac2
to
25d2a9c
Compare
dylanb
approved these changes
Nov 24, 2021
This was referenced Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<li>as children of<menu>Closes issue: #3284