Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Incomplete fallback message was missing #3302

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

WilcoFiers
Copy link
Contributor

A bug in the build step caused the incomplete fallback message to be an empty object, rather than a string. When an error occurred, rather than failing gracefully this caused infinite recursion. This change prevents that.

Closes issue: #3289

@WilcoFiers WilcoFiers requested a review from a team as a code owner November 18, 2021 18:00
@WilcoFiers WilcoFiers merged commit f23d8c8 into develop Nov 24, 2021
@WilcoFiers WilcoFiers deleted the missing-fallback-msg branch November 24, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants