fix: get shadow DOM tests all passing #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the first totally clean build of the shadow DOM branch since we broke the rules :-) |
marcysutton
reviewed
Jul 20, 2017
| @@ -123,6 +123,9 @@ axe.utils.getFlattenedTree = function (node, shadowId) { | |||
| axe.utils.getNodeFromTree = function (vNode, node) { | |||
| var found; | |||
|
|
|||
| if (vNode.actualNode === node) { | |||
There was a problem hiding this comment.
Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?
There was a problem hiding this comment.
makes the additional test pass - specifically when some of our utilities look for the 'html' node in the vrtual tree, it was not being found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.