Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postinstall): use node, more conditionals #520

Merged
merged 2 commits into from
Sep 12, 2017
Merged

fix(postinstall): use node, more conditionals #520

merged 2 commits into from
Sep 12, 2017

Conversation

marcysutton
Copy link
Contributor

Closes #516

@marcysutton
Copy link
Contributor Author

marcysutton commented Sep 12, 2017 •
edited
Loading

One caveat is I had to install fs-extra as a dependency to be able to copy the file, as fs.copyFile is only available in Node 8.5.0. Streams weren't cutting it for a pre commit-hook. I could potentially change fs-extra to a devDependency and use both fs and fs-extra in the script, if we don't want the dependency in axe-core.

EDIT: I decided to go ahead and move it after testing on Windows. It's nice not having the dependency tree listed out when installing axe-core since you aren't using the modules in the tree.

isner
isner approved these changes Sep 12, 2017
View reviewed changes
Copy link
Contributor

@isner isner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! INVALID COMMIT MSG: does not match "<type>(<scope>): <subject>" ! was: blah

@marcysutton
Copy link
Contributor Author

Woo! Thanks @isner

@marcysutton marcysutton merged commit 98fac8a into develop-2x Sep 12, 2017
@marcysutton marcysutton deleted the fix-postinstall branch September 12, 2017 18:42
marcysutton added a commit that referenced this pull request Sep 12, 2017
@marcysutton
fix(postinstall): use node, more conditionals (#520)
f5b5299 
* fix(postinstall): use node, more conditionals

Closes #516

* chore: move fs-extra to devDependencies
marcysutton added a commit that referenced this pull request Dec 11, 2017
@marcysutton
fix(postinstall): use node, more conditionals (#520)
0259479 
* fix(postinstall): use node, more conditionals

Closes #516

* chore: move fs-extra to devDependencies
marcysutton added a commit that referenced this pull request Dec 12, 2017
@marcysutton
fix(postinstall): use node, more conditionals (#520)
54f7ddd 
* fix(postinstall): use node, more conditionals

Closes #516

* chore: move fs-extra to devDependencies
@dependencies dependencies bot mentioned this pull request Dec 19, 2017
Merged
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this pull request Nov 24, 2023
@Kosai106
feat: include missing cache file (dequelabs#520)
9b2b375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isner isner isner approved these changes

@dylanb dylanb Awaiting requested review from dylanb

@WilcoFiers WilcoFiers Awaiting requested review from WilcoFiers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcysutton @isner