fix(required-children): add combobox > listbox exception #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer requires a collapsed combobox to own a child listbox #548
|
Done. |
Allows role=textbox child to be missing from <input type=search role=combobox> parent Closes #549
WilcoFiers
reviewed
Oct 9, 2017
lib/checks/aria/required-children.js
Outdated
| @@ -51,7 +51,7 @@ function missingRequiredChildren(node, childRoles, all, role) { | |||
|
|
|||
| // remove 'textbox' from missing roles if combobox is a native input | |||
| var textboxIndex = missing.indexOf('textbox'); | |||
| if (textboxIndex >= 0 && node.tagName === 'INPUT' && node.type === 'text') { | |||
| if (textboxIndex >= 0 && node.tagName === 'INPUT' && ['text', 'search'].indexOf(node.type) >= 0) { | |||
There was a problem hiding this comment.
I think there are probably other types that make sense too.
There was a problem hiding this comment.
Good point. Which other types are you thinking of? To me, the only other types that seem reasonable to use as the basis of a combobox are "email" and "url". Beyond that, "tel" might be worth supporting.
There was a problem hiding this comment.
I added "email", "url", and "tel" to the excepted input types.
… > textbox Allows role=textbox to be missing from <input type=email|url|tel role=combobox> Related to #549
WilcoFiers
approved these changes
Oct 11, 2017
This was referenced Dec 11, 2017
mrtnvh
pushed a commit
to mrtnvh/axe-core
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer requires a collapsed combobox to own a child listbox.
The relevant ARIA 1.1 spec: https://www.w3.org/TR/wai-aria-1.1/#combobox
#548