Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanupPlugins() will throw TypeError if its arguments are undefined. #705

Closed
lsiden opened this issue Jan 31, 2018 · 1 comment
Closed

cleanupPlugins() will throw TypeError if its arguments are undefined. #705

lsiden opened this issue Jan 31, 2018 · 1 comment
Assignees
@lsiden

Comments

@lsiden
Copy link
Contributor

lsiden commented Jan 31, 2018

cleanupPlugins() takes two args: resolve and reject. Both must be defined by the caller or it will throw a TypeError (along with a different type of error).

Each of these arguments should have default values.
@lsiden lsiden added the aXe 3.0 label Jan 31, 2018
@lsiden lsiden self-assigned this Jan 31, 2018
@WilcoFiers
Copy link
Contributor

Sounds reasonable. We'd welcome a pull request if you've got the time for it.

@lsiden lsiden mentioned this issue Feb 1, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lsiden lsiden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lsiden @WilcoFiers