fix: log "iframe warning" to stderr (#102)

This patch moves the "iframe warning" log to stderr (from stdout). Ref: dequelabs/axe-cli#87
dequelabs · Mar 6, 2019 · bb4fb2c · bb4fb2c
1 parent 417f4ae
commit bb4fb2c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/lib/axe-injector.js b/lib/axe-injector.js
@@ -17,7 +17,7 @@ class AxeInjector {
 
     this.didLogError = true;
     // eslint-disable-next-line no-console
-    console.log('Failed to inject axe-core into one of the iframes!');
+    console.error('Failed to inject axe-core into one of the iframes!');
   }
 
   // Get axe-core source (and configuration)

diff --git a/test/unit/axe-injector.js b/test/unit/axe-injector.js
@@ -46,9 +46,24 @@ describe('AxeInjector', () => {
   });
 
   describe('errorHandler', () => {
+    // See https://github.com/dequelabs/axe-cli/issues/87.
+    it('writes to stderr (not stdout)', () => {
+      const injector = new AxeInjector({ driver: new MockWebDriver() });
+      const logSpy = sinon.spy(console, 'log');
+      const errorSpy = sinon.spy(console, 'error');
+
+      injector.errorHandler();
+
+      assert.equal(logSpy.callCount, 0);
+      logSpy.restore();
+
+      assert.equal(errorSpy.callCount, 1);
+      errorSpy.restore();
+    });
+
     it('only logs once', () => {
       const injector = new AxeInjector({ driver: new MockWebDriver() });
-      const spy = sinon.spy(console, 'log');
+      const spy = sinon.spy(console, 'error');
 
       injector.errorHandler();
       injector.errorHandler();