This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
fix: Improve error message when an iframe was removed #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dylanb
reviewed
Jul 9, 2019
lib/axe-injector.js
Outdated
| console.error('Failed to inject axe-core into one of the iframes!'); | ||
| if (err instanceof StaleElementReferenceError) { | ||
| // eslint-disable-next-line no-console | ||
| console.error('Tried to inject into a removed iframe. Please ensure the page has settled.') |
There was a problem hiding this comment.
Can we change this to: Tried to inject into a removed iframe. This will not affect the analysis of the rest of the page but you might want to ensure the page has finished updating before starting the analysis
stephenmathieson
previously requested changes
Jul 9, 2019
stephenmathieson
approved these changes
Jul 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trying many things, this is the best we can do. When a
StaleElementReferenceErrorwe have a reference to an element that was either deleted or detached from the DOM. And we shouldn't be doing anything that could cause either of those things to occur. If a user's page causes Selenium to throw aStaleElementReferenceErrorthen we our Axe results probably won't be consistent anyways.So, the best solution is to inform the user that it is their page that is acting up and that it is their responsibility to get the page in a stable state before running Axe on it.
Closes issue: https://github.com/dequelabs/attest-node-suite/issues/246
Reviewer checks
Required fields, to be filled out by PR reviewer(s)