Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update basic accordions to match UXPin #856

Open
bobbyomari opened this issue Jan 18, 2023 · 4 comments · May be fixed by #1313
Open

Update basic accordions to match UXPin #856

bobbyomari opened this issue Jan 18, 2023 · 4 comments · May be fixed by #1313
Assignees
@orest-s
Labels
design sync Issues that need design synchronization enhancement New feature or request
Milestone
Cauldron UX Sync

Comments

@bobbyomari
Copy link
Contributor

bobbyomari commented Jan 18, 2023 •
edited by scurker
Loading

The current accordion in Cauldron is outdated and needs to be updated to the latest iteration of accordion styles with two versions - basic and advanced. We no longer use the blue bar as a hover state and has been updated as such to be used as an active state instead (when the accordion item is open). There are also some changes to the icon used, box-shadow (only applied when accordion group is open), and spacing.

UXPin
@bobbyomari bobbyomari changed the title Update accordion to match UXPin Update accordions to match UXPin Jan 18, 2023
@dequejenn dequejenn mentioned this issue Jan 20, 2023
Closed
@scurker scurker added the enhancement New feature or request label Feb 21, 2023
@scurker
Copy link
Member

scurker commented Feb 21, 2023

Related: #716

Update styles and add "advanced variant of accordion". The advanced variant of the accordion would need to use ExpandCollapsePanel under the hood and match the styles of the accordion in order to support the action buttons on the right side of the header.

@scurker
Copy link
Member

scurker commented Feb 21, 2023

Also related #902

@scurker scurker mentioned this issue Mar 7, 2023
Closed
@scurker
Copy link
Member

scurker commented Mar 7, 2023

The box shadow needs to encompass the full element when expanded, not just the panel.

@scurker scurker mentioned this issue Mar 7, 2023
Closed
@scurker
Copy link
Member

scurker commented Mar 7, 2023

Regarding the spacing of the component, the trigger text should be aligned to the left the same as the content text should be. I think we just need to adjust the left padding of the trigger element.

@scurker scurker added this to the Cauldron UX Sync milestone Mar 7, 2023
This was referenced Aug 15, 2023
Closed
Merged
@bobbyomari bobbyomari changed the title Update accordions to match UXPin Update basic accordions to match UXPin Oct 3, 2023
@orest-s orest-s self-assigned this Jan 10, 2024
@orest-s orest-s linked a pull request Jan 10, 2024 that will close this issue
Open
@scurker scurker added the design sync Issues that need design synchronization label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orest-s orest-s

Labels
design sync Issues that need design synchronization enhancement New feature or request
Projects
None yet
Milestone
Cauldron UX Sync
Development

Successfully merging a pull request may close this issue.

fix(style): basic accordion uxpin sync dequelabs/cauldron
3 participants
@scurker @bobbyomari @orest-s