This repository has been archived by the owner on Mar 19, 2021. It is now read-only.
feat(*): convert to typescript #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmathieson
previously approved these changes
Feb 20, 2020
scurker
reviewed
Feb 20, 2020
scurker
reviewed
Feb 20, 2020
scurker
approved these changes
Feb 20, 2020
stephenmathieson
approved these changes
Feb 21, 2020
2 tasks
|
Has this been released? Version pulled from npm does not include type declarations and is listed on npmjs.com as 3.4.1, whereas develop is currently at 3.4.0? |
|
It does not appear types was released to npm. As for the version discrepancy, seems we never pulled master back into develop after the release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was a bit tricky with all the private property lookups in axe-core and React.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)