k9s 0.24.8 edit needs an extra keystroke to process

[MrLuje]

Describe the bug
Hitting "E" for the edit view works weirdly, it needed an extra keypress to really open the editor

A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

• Open k9s and go to any resources, like pods
• Hit "e" for the edit view
  nothing happen here, I'm still on the pods view... but if I press another key like space or enter, it opens the editor

Expected behavior
I should be in my editor opened on the selected pod after hitting "Edit"

Versions (please complete the following information):

• OS: Windows WSL2 + Windows Terminal
• K9s: 0.24.8
• K8s: 1.17.17

I reverted to 0.24.7 to confirm and it properly works on 0.24.7 but not on 0.24.8

[MrLuje]

Just noticed CTRL+C also need an extra keypress to exit

[dyipon]

Shell needs extra keypress too

[derailed]

@MrLuje @dyipon - I can't seem to repro this on my loaner box. Running windows 10 + powerhell. Pod edit + shell in are working as expected on v0.24.8 ie no additional input.
How did you guys install k9s?
Any windows pro here care to shade some light? My window fu is pretty much tapped out ;(

[dyipon]

@derailed - me @ debian buster, and k9s installed manually with wget. It worked until this release

[MrLuje]

@derailed Installed with homebrew
I also tested with regular cmd.exe (as I'm using Windows Terminal usually) and I still hit the issue

[MrLuje]

@derailed A few more tests :

• compiled k9s from source 0.24.8 on windows, no bug on the windows binary
• compiled k9s from source 0.24.8 on wsl2, bug again on the linux binary
• compiled on wsl2 an older version of k9s (tried every minor from 0.24.7 to 0.24.5) also bug (even though your binaries for the same versions are fine 🤔)

[derailed]

@MrLuje Once again Thank you so much for the extra details! I am very much appreciating your help and support tracking this down. Honestly, I am not sure I've got this?? Crossing fingers and toes on this one.
Let's give v0.24.9 a spin and see if we're happier... Please reopen if we've got a dud. Thank you!!

[dyipon]

Extra keystroke doesn't need anymore, so ctrl-c and shell works again. But if I enter into a shellpod, an extra '?' key presented in the prompt. Not a big deal, just have to press a backspace. Tried on debian linux.

[MrLuje]

Toes did the trick 😁
As stated by @dyipon, there are remaining stuff when opening a shell (^ or ? depending on the previous action) but it's much better already

[derailed]

@MrLuje @dyipon Serenity now! Thank you both for reporting back. Will track down this last issue. Tx!