You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Whenever i try to benchmark a pod in my windows machines the benchmark would start but not show up in the :benchmark menu nor in the view benchmarks section of portforward.
Reviewing the logs I see this:
�[90m12:05PM�[0m �[1m�[31mERR�[0m�[0m Saving Benchmark �[31merror=�[0m�[31m"open C:\\Users\\bfren\\AppData\\Local\\Temp\\k9s-bench-LAPTOP-91BCJNIT\\bfren\\CLUSTER\\NAMESPACE_POD||30080:3000_1638788739485939400.txt: The filename, directory name, or volume label syntax is incorrect."�[0m
The path contains two illegal characters for Windows, : and |. Apparently, #746 partially fixed this by sanitizing : but failed to include |.
I guess the fix should be as simple as adding the whole list of illegal characters for windows here
Also, as you can see logs seem to be full of illegal characters, probably related to using colors in the log, which should only be printed to the console and not saved to a file.
To Reproduce
Steps to reproduce the behavior:
Open a port-frward
Start a benchmark
try to open the aforementioned benchmark.
Expected behavior
The benchmark should appear under :benchmark
Versions (please complete the following information):
OS: Windows 10-11
K9s: v0.25.8
The text was updated successfully, but these errors were encountered:
Whenever i try to benchmark a pod in my windows machines the benchmark would start but not show up in the
:benchmark
menu nor in theview benchmarks
section ofportforward
.Reviewing the logs I see this:
The path contains two illegal characters for Windows,
:
and|
. Apparently, #746 partially fixed this by sanitizing:
but failed to include|
.I guess the fix should be as simple as adding the whole list of illegal characters for windows here
k9s/internal/dao/screen_dump.go
Line 19 in f97bcea
Also, as you can see logs seem to be full of illegal characters, probably related to using colors in the log, which should only be printed to the console and not saved to a file.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The benchmark should appear under
:benchmark
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: