Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight wording error when port forward already exists #1569

Closed
GCrispino opened this issue May 24, 2022 · 1 comment
Closed

Slight wording error when port forward already exists #1569

GCrispino opened this issue May 24, 2022 · 1 comment

Comments

@GCrispino
Copy link




Is your feature request related to a problem? Please describe.
This would be a small wording change request. When we try to open a port-forward on a pod that already has one, the following message is printed:

A PortForward already exist for pod *podname*

Describe the solution you'd like
I believe the correct phrasing would be

A PortForward already *exists* for pod *podname*

Describe alternatives you've considered
N/A

Additional context
There are two occurrences of this wording on the codebase:

  1. https://github.com/derailed/k9s/blob/master/internal/view/pf_extender.go#L60
  2. https://github.com/derailed/k9s/blob/master/internal/view/container.go#L177

I could fix them if the maintainers agree this should be changed.

Cheers!

@derailed
Copy link
Owner

@GCrispino Thank you! Fixed v0.25.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants