Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands Mark Range and Mark Clear do not work #2187

Closed
Timo-Weike opened this issue Aug 3, 2023 · 4 comments · Fixed by #2927
Closed

Commands Mark Range and Mark Clear do not work #2187

Timo-Weike opened this issue Aug 3, 2023 · 4 comments · Fixed by #2927
Labels
bug Something isn't working question Further information is requested

Comments

@Timo-Weike
Copy link




Describe the bug
The "Mark Clear" and "Mark Range" commands do not work.

To Reproduce
Go to a view of all pods and try the "Mark Range" (ctrl-space) or "Mark Clear" (ctrl-\) and see that they don't work.

Versions (please complete the following information):

  • OS: Microsoft Windows 11 Enterprise 10.0.22621
  • K9s: v0.27.4
  • K8s: 1.26.3
  • Shell: PoweshellCore 7.3.5
@antoinemartinoctave
Copy link

Note that it works on Linux. Doing the same on Windows Subsystem For Linux (WSL) on the same machine works.

@Bec-k
Copy link

Bec-k commented Oct 6, 2023

Does not work on Linux either (Ubuntu)

@derailed
Copy link
Owner

@Timo-Weike Can't seem to repro on v0.32.5 on both linux and osx. Could you try the latest and see if we're happier?
if not please include the debug logs so we can track this down.

@derailed derailed added the question Further information is requested label Oct 30, 2024
@Timo-Weike
Copy link
Author

@Timo-Weike Can't seem to repro on v0.32.5 on both linux and osx. Could you try the latest and see if we're happier? if not please include the debug logs so we can track this down.

Running k9s --logLevel trace, and then do

  • pressing crtl-space and while pressed going down using the arrow key does not mark the range
    -pressing ctrl-space and then going down with the arrow-key and again pressing ctrl-space only marks the first and last element
  • for clear all marked, I need to press ctrl-\, the \ char is on my german keyboard layout on the key right from the 0 key and I need to hold AltGr to type a \, so I'm not sure what k9s expects to be pressed exactly. However no of ctrl and the other controll keys and the key with the \ , triggers the clearing of the marked elements.
  • also to note is that in the in the command input I can type \ without problem.
�[90m1:06PM�[0m �[32mINF�[0m �[1m🐶 K9s starting up...�[0m
�[90m1:06PM�[0m �[34mTRC�[0m [CAN] v1/namespaces(""/"") <[list]>
�[90m1:06PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc00090c7e0), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:06PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:06PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:06PM�[0m DBG Active Context "<cluster-name>"
�[90m1:06PM�[0m �[32mINF�[0m �[1m✅ Kubernetes connectivity�[0m
�[90m1:06PM�[0m DBG No custom skin found. Using stock skin
�[90m1:06PM�[0m DBG Factory START with ns `"<namespace>"
�[90m1:06PM�[0m �[34mTRC�[0m [CAN] v1/nodes(""/"") <[list]>
�[90m1:06PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc000375ce0), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:06PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:06PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:06PM�[0m �[34mTRC�[0m [CAN] metrics.k8s.io/v1beta1/nodes(""/"") <[list]>
�[90m1:06PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc00090ca80), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:06PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:06PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:06PM�[0m DBG Fetching latest k9s rev...
�[90m1:06PM�[0m DBG K9s latest rev: "v0.32.5"
�[90m1:06PM�[0m �[34mTRC�[0m [CAN] apiextensions.k8s.io/v1/customresourcedefinitions(""/"") <[list]>
�[90m1:06PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc000384150), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:06PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:06PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:06PM�[0m DBG No custom skin found. Using stock skin
�[90m1:06PM�[0m �[34mTRC�[0m [CAN] apps/v1/deployments("<namespace>"/"") <[list]>
�[90m1:06PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc000906230), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:06PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:06PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](0) 0s 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 22.2036ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.4625ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.0276ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 7.714ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 6.126ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.2973ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 3.8158ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.2395ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.3881ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.0873ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 3.0452ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.8887ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 5.9742ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 2.7999ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 5.2228ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 3.6432ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 2.9673ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 3.3453ms 
�[90m1:06PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](13) 4.5205ms 
�[90m1:07PM�[0m �[32mINF�[0m �[1m🐶 K9s starting up...�[0m
�[90m1:07PM�[0m �[34mTRC�[0m [CAN] v1/namespaces(""/"") <[list]>
�[90m1:07PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc000ac48c0), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:07PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:07PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:07PM�[0m DBG Active Context "<cluster-name>"
�[90m1:07PM�[0m �[32mINF�[0m �[1m✅ Kubernetes connectivity�[0m
�[90m1:07PM�[0m DBG No custom skin found. Using stock skin
�[90m1:07PM�[0m DBG Factory START with ns `"<namespace>"
�[90m1:07PM�[0m �[34mTRC�[0m [CAN] v1/nodes(""/"") <[list]>
�[90m1:07PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc0000fa230), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:07PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:07PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:07PM�[0m �[34mTRC�[0m [CAN] metrics.k8s.io/v1beta1/nodes(""/"") <[list]>
�[90m1:07PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc000ac50a0), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:07PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:07PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:07PM�[0m DBG Fetching latest k9s rev...
�[90m1:07PM�[0m DBG K9s latest rev: "v0.32.5"
�[90m1:07PM�[0m �[34mTRC�[0m [CAN] apiextensions.k8s.io/v1/customresourcedefinitions(""/"") <[list]>
�[90m1:07PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc00036a070), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:07PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:07PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:07PM�[0m DBG No custom skin found. Using stock skin
�[90m1:07PM�[0m �[34mTRC�[0m [CAN] apps/v1/deployments("<namespace>"/"") <[list]>
�[90m1:07PM�[0m �[34mTRC�[0m   Spec: v1.SelfSubjectAccessReviewSpec{ResourceAttributes:(*v1.ResourceAttributes)(0xc00036a150), NonResourceAttributes:(*v1.NonResourceAttributes)(nil)}
�[90m1:07PM�[0m �[34mTRC�[0m   Auth: true ["RBAC: allowed by ClusterRoleBinding \"aks-cluster-admin-binding-aad\" of ClusterRole \"cluster-admin\" to Group \"xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx\""]
�[90m1:07PM�[0m �[34mTRC�[0m   <<<nil>>>
�[90m1:07PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](0) 0s 
�[90m1:07PM�[0m �[34mTRC�[0m Refresh [apps/v1/deployments](0) 166.2µs 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants