You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, I'm new to this project and interested in picking this up.
I've "done" the change here master...xabrickx:update/115_normalize_requests
but didn't want throw PR at you without saying any thing. My change creates simple wrappers for request/response and reroutes the current requests, including the lingering urllib requests, through them.
I'm happy to simplify this and ditch the wrapper if you prefer but thought the benefits of standardizing the requests would outweigh the additional complexity. Please let me know if I've missed anything or you have any recommendations?
My change creates simple wrappers for request/response and reroutes the current requests,
Most excellent, this needed doing anyways considering the user-agent string requirement. I'll be looking over this but at a glance it looks very solid.
There is a mish-mash of various request libraries used here. I plan on just swapping them all to requests
The text was updated successfully, but these errors were encountered: