Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow ERC20 allowance #1

Open
Zergity opened this issue May 21, 2023 · 0 comments
Open

Shadow ERC20 allowance #1

Zergity opened this issue May 21, 2023 · 0 comments
Assignees
@BerlinP

Comments

@Zergity
Copy link
Contributor

Zergity commented May 21, 2023 •
edited
Loading

duplicate allowance logic from ERC20 to Shadow (using s_allowances in Shadow contract)

to check the approval:

  • if 1155.approveForAll, then return uint.max
  • otherwise, return s_allwances[owner][spender]

Note: make sure to utilize the max allowance logic (ethereum/EIPs#717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BerlinP BerlinP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zergity @BerlinP