Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition class_name conflicts easily #57

Open
WolfgangSenff opened this issue Nov 20, 2023 · 2 comments
Open

Transition class_name conflicts easily #57

WolfgangSenff opened this issue Nov 20, 2023 · 2 comments
Labels
enhancement New feature or request planned The issue has been added to a schedule for implementation.

Comments

@WolfgangSenff
Copy link

Hi there!

I have noticed that the class_name of Transition, which you use, conflicts very easily with lots of other projects. I was wondering if it could be changed to something like StateChartTransition? I'm happy to open a PR for this, let me know if you'd like me to change that. I only noticed because it conflicts with my public game template, which is in pretty widespread use, so I'll be updating my template as well (we use Transition for scene transitions as an autoload, so that's where the conflict comes in, and Godot's error reporting on this is...poor, to say the least), but in general Transition seems to be used regularly across several projects, not just our two, meaning it's going to come up more often I should think, if StateCharts becomes very popular.

@derkork
Copy link
Owner

derkork commented Nov 21, 2023

Changing the name itself is not going to be a lot of work, but it will break all existing scenes that use the state charts. I will have to do some tests to find a good way to make this change without breaking people's projects. It would really suck if you designed a big state chart and then your data is gone and you'd have to do it again.

I really wish there was a way of creating namespaces so this kind of problem wouldn't exist, but this is probably not coming any time soon (godotengine/godot-proposals#1566).

@derkork derkork added the enhancement New feature or request label Nov 21, 2023
@derkork
Copy link
Owner

derkork commented Nov 21, 2023

So looks like the scenes are actually pretty unimpressed by the rename, which is a good thing. So this would mainly break existing scripts that use the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned The issue has been added to a schedule for implementation.
Projects
None yet
Development

No branches or pull requests

2 participants