Add CSS variables for background colors #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! 👋 Sorry to bother you, @krassowski, but any chance you could review this MR, please? Thanks! |
krassowski
approved these changes
Dec 19, 2024
|
Thanks, @krassowski! |
|
@joaopalmeiro if you have not signed it before you may need to sign CLA for this to be merged as per https://github.com/deshaw/jupyterlab-execute-time/blob/master/CONTRIBUTING.md |
|
Thanks for the reminder! I signed at the time I opened MR. Is there any way to confirm? |
|
Confirmed @joaopalmeiro signed. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
Hi! 👋
As per the discussion on #124, here is a proposal to include two CSS variables to style the (animated) background colors for this extension. The highlight color fallback has also been updated. Let me know what you think, please!
Screen.Recording.2024-07-15.at.18.23.42.mov