Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightwatch tab OBJTYPE does not work properly #209

Closed
sheejong opened this issue Jan 8, 2021 · 3 comments
Closed

Nightwatch tab OBJTYPE does not work properly #209

sheejong opened this issue Jan 8, 2021 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sheejong
Copy link

sheejong commented Jan 8, 2021

Under "Spectra" tab, "objtype" does not really show the type of each object except for SKY.
It would be useful if this tab works properly.

@sbailey
Copy link
Collaborator

sbailey commented Jan 8, 2021

Thanks for the report. I suspect that it was developed for main survey targeting columns and bits, but doesn't yet support CMX/SV data. If that is the case, desitarget.targets.main_cmx_or_sv is the helper function to sort those out.

@deisenstein deisenstein added the good first issue Good for newcomers label Jan 8, 2021
@parfa30 parfa30 self-assigned this Jun 2, 2021
@parfa30
Copy link
Contributor

parfa30 commented Jun 17, 2021

This is still happening for the main survey tiles. I believe what is happening is that during desispec.preproc, the wrong fibermap file is being used and it ends up writing an "empty fibermap". This all needs to be fixed in desispec, so I wrote issue 1315 there.

@sybenzvi
Copy link
Contributor

This should be fixed as of the merger of PR #253, though the spectra menu at NERSC is broken (#255).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants