-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rrdesi option to output model fits #270
Comments
@sbailey Now, there can be a few choices:
In any case, we should provide a small function to extract the model and spectra from any of these files? Archetype+Legendre terms: Yes, this is an important point; if we want to include both the PCA and Archetype models, then (2) seems a better solution. But we will need surgery in the redrock to store those coefficients separately. I am happy to help with this issue. |
@abhi0395 thanks for volunteering for this. Let's not post-facto add it to the coadd files, since that would break the "write once read many" paradigm for pipeline dataflow and it would make those files even larger. Let's keep the models in their own separate file, not adding to the existing redrock*.fits files since that would make them much much larger to download. We could use a structure like the existing coadd files where there would be Let's start with the "small function to extract the model and spectra", regardless of the details of how we store that in a file. I'll open a separate ticket about how to store PCA/NMF vs. Archetype vs. Legendre coeffs, which is a related but somewhat different question from how we store the models. |
@sbailey Thanks for the suggestions. Sure, I will start looking into these small functions for doing such specific tasks. |
Hi @abhi0395 , adding a comment here to re-iterate that I'll be interested in trying out the function that you are writing and in particular testing it on spectra after they have been coadded across cameras. Please keep me posted! |
@stephjuneau Thanks, sure I'll keep you posted. |
Implemented in PR #283. Closing. |
Add
rrdesi --model filename.fits
option to output pre-rendered models. A few choices that need to be made:The text was updated successfully, but these errors were encountered: