Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual override environment variable #68

Closed
smashwilson opened this issue Mar 2, 2017 · 1 comment
Closed

Manual override environment variable #68

smashwilson opened this issue Mar 2, 2017 · 1 comment

Comments

@smashwilson
Copy link

Support an environment variable that lets users override the bundled binaries with an external git binary that they've built elsewhere. This provides advanced users an escape hatch to use on older Linux distributions than we support, as opposed to them just being SOL.

We'd have to be careful to specify the git version we expect -- part of the benefit of using git-kitchen-sink is not having to worry about compatibility with older git versions, after all. Maybe include the git version in the environment variable name?

As suggested in desktop/dugite-native#13 (comment).

@shiftkey
Copy link
Member

shiftkey commented Mar 2, 2017

Prior art: we already set a TEST_WITH_LOCAL_GIT flag when executing tests which change the behaviour of resolving the Git directory.

https://github.com/desktop/git-kitchen-sink/blob/master/lib/git-process.ts#L76-L82

We could make this environment variable more generic, e.g. USE_ALTERNATE_GIT=/some/path, and trust this value instead of doing the platform-specific lookup we're currently doing. This would mean we'd trust the local version of Git to be configured right, and not set GIT_TEMPLATE_DIR and PREFIX on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants