feat: add multi test utils #29

dadamu · 2022-07-27T12:13:07Z

This PR implements DesmosApp for contract integration tests.

codecov · 2022-07-27T12:19:07Z

Codecov Report

Merging #29 (6b4d54c) into main (168ddc3) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   90.94%   91.03%   +0.08%     
==========================================
  Files          27       27              
  Lines        2276     2276              
==========================================
+ Hits         2070     2072       +2     
+ Misses        206      204       -2

Impacted Files	Coverage Δ
packages/bindings-test/src/chain_communication.rs	`0.00% <ø> (ø)`
packages/bindings/src/mocks.rs	`98.14% <ø> (ø)`
packages/bindings/src/subspaces/mocks.rs	`100.00% <ø> (ø)`
packages/bindings/src/subspaces/querier.rs	`91.70% <ø> (ø)`
packages/bindings/src/msg.rs	`81.25% <0.00%> (+3.12%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f7d1b...6b4d54c. Read the comment docs.

dadamu · 2022-07-28T11:30:39Z

packages/bindings/src/test_utils.rs

+
+/// Represents the implementation of [`Module`](cw_multi_test::Module) for handling the desmos execution and query messages.
+#[derive(Default)]
+pub struct DesmosKeeper {}


Instead of implementing the whole state inside desmos chain, I make DesmosKeeper as a module which always returns the successful response with proper events. Devs can handle event in the reply phase as the sample.

dadamu · 2022-07-28T11:32:38Z

packages/bindings/src/test_utils.rs

+}
+
+/// Represents failing desmos app always returning error.
+pub type FailingDesmosApp = BasicApp<DesmosMsg, DesmosQuery>;


This is for testing the reply function if the sub msg is failed.

leobragaz · 2022-07-28T13:45:34Z

Looks good to me! Maybe use the // DONTCOVER notation in those file that can be excluded from the coverage.
This will help to raise it a little bit matching the real coverage of the bindings themselves

manu0466 · 2022-07-28T14:42:56Z

.github/workflows/desmos_bindings.yml

@@ -179,3 +179,7 @@ jobs:
      - name: Build feature (mocks)
        working-directory: ./packages/bindings
        run: cargo build --no-default-features --features mocks
+


This test can be removed

manu0466 · 2022-07-28T14:43:10Z

packages/bindings/Cargo.toml

@@ -33,4 +35,5 @@ reactions = []
 query = []
 msg = []
 mocks = ["query"]
+integration-test = ["query", "msg", "mocks"]


This feature can be removed

Suggested change

integration-test = ["query", "msg", "mocks"]

manu0466 · 2022-07-28T14:43:40Z

packages/bindings/src/lib.rs

@@ -24,4 +24,7 @@ pub mod relationships;
 pub mod reports;
 #[cfg(feature = "subspaces")]
 pub mod subspaces;
+#[cfg(feature = "integration-test")]


Instead of using a custom feature is better to use the #[cfg(not(target_arch = "wasm32"))] so that the testing_utils module will be automaticaly compiled when performing the integration tests.

Suggested change

#[cfg(feature = "integration-test")]

#[cfg(not(target_arch = "wasm32"))]

You are right. I didn't think about it. Since it is a lib that mock desmos app for integration test, I use mocks as its feature.

packages/bindings/src/test_utils.rs

dadamu · 2022-07-28T15:12:43Z

packages/bindings/Cargo.toml

 cosmwasm-std = { version = "1.0.0" }
+cw-multi-test = { version = "0.13.4", optional = true }


Not sure why it has conflict with test-contract cosmwasm-std, so I make it optional and only use it when the feature is mocks.

I tried to remove the optional flag and the dependency requirement with the mocks feature and on my computer running cargo build everiting compiles correctly.
Can you tell me the command that triggers the error for you?

I'm using:

cargo 1.61.0 (a028ae4 2022-04-29)

rustc 1.61.0 (fe5b13d68 2022-05-18)

The error happens while compileing the test contract with command cargo optimize.
It shows error as follows:

Compiling cw-multi-test v0.13.4 error[E0432]: unresolved import `cosmwasm_std::testing` --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/cw-multi-test-0.13.4/src/app.rs:5:19 | 5 | use cosmwasm_std::testing::{mock_env, MockApi, MockStorage}; | ^^^^^^^ could not find `testing` in `cosmwasm_std` error[E0432]: unresolved import `cosmwasm_std::testing` --> /usr/local/cargo/registry/src/github.com-1ecc6299db9ec823/cw-multi-test-0.13.4/src/wasm.rs:24:19 | 24 | use cosmwasm_std::testing::mock_wasmd_attr; | ^^^^^^^ could not find `testing` in `cosmwasm_std`

Both cargo and rustup version on my PC are 1.64.0-nightly.

Ok found the issue, becouse cw-multi-test is marked as dependency inisde the desmos-binding toml it's compiled also when targeting wasm32-unknown-unknown.
cosmwasm-std expose the testing module only when not compiling for wasm32-unknown-unknown causing this compilation error.
Moving the cw-multi-test into the dev-dependencies will fix this issue

packages/bindings/Cargo.toml

dadamu · 2022-07-29T12:25:24Z

.github/workflows/desmos_bindings.yml

@@ -175,7 +175,3 @@ jobs:
      - name: Build feature (msg+reports)
        working-directory: ./packages/bindings
        run: cargo build --no-default-features --features msg,reports
-
-      - name: Build feature (mocks)


Remove mocks feature building since it is the mock lib for testing and it occurs error related to cw-multi-test importing.

dadamu added 3 commits July 27, 2022 18:22

feat: init desmos keeper for integration test

1c8bd0a

test: added desmos app unit tests

e0611d6

chore: update cargo lock

a3b9285

dadamu added 5 commits July 28, 2022 12:14

docs: added documents

648a857

chore: run cargo fmt

5d34941

feat: added failing desmos module

a311363

ci: added build test for integration-test

2156d96

feat: built all module handlers to return proper events

23e252f

dadamu marked this pull request as ready for review July 28, 2022 11:19

dadamu requested review from manu0466 and leobragaz July 28, 2022 11:19

dadamu commented Jul 28, 2022

View reviewed changes

fix: unsafe-reset-all command

f03d504

leobragaz approved these changes Jul 28, 2022

View reviewed changes

fix: test contract dependency conflict

5912740

manu0466 reviewed Jul 28, 2022

View reviewed changes

dadamu added 2 commits July 28, 2022 22:57

fix: fixed dependency conflict

1200194

fix: apply suggestions

a262f7c

dadamu commented Jul 28, 2022

View reviewed changes

dadamu added 4 commits July 28, 2022 23:27

fix: fix cargo build mocks feature error

49327e1

fix: use no coverage tag

2297b8a

fix: remove unreachable

8eaffa4

fix: coverage tag

2bfed85

dadamu requested a review from manu0466 July 28, 2022 16:27

manu0466 reviewed Jul 29, 2022

View reviewed changes

packages/bindings/Cargo.toml Outdated Show resolved Hide resolved

dadamu added 2 commits July 29, 2022 19:53

fix: move cw-multi-test to dev dependancy

813a52b

fix: move cw-multi-test to dev dependancy

fff0f95

ci: remove mocks feature build test

6b4d54c

dadamu commented Jul 29, 2022

View reviewed changes

dadamu requested a review from manu0466 July 29, 2022 12:27

manu0466 approved these changes Jul 29, 2022

View reviewed changes

manu0466 merged commit 2904dff into main Jul 29, 2022

manu0466 deleted the paul/DCD-57/add-multi-test-utils branch July 29, 2022 13:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add multi test utils #29

feat: add multi test utils #29

dadamu commented Jul 27, 2022

codecov bot commented Jul 27, 2022 •

edited

Loading

dadamu Jul 28, 2022 •

edited

Loading

dadamu Jul 28, 2022

leobragaz commented Jul 28, 2022

manu0466 Jul 28, 2022

manu0466 Jul 28, 2022

manu0466 Jul 28, 2022

dadamu Jul 28, 2022 •

edited

Loading

dadamu Jul 28, 2022 •

edited

Loading

manu0466 Jul 29, 2022

dadamu Jul 29, 2022

manu0466 Jul 29, 2022

dadamu Jul 29, 2022 •

edited

Loading

	#[cfg(feature = "integration-test")]
	#[cfg(not(target_arch = "wasm32"))]

		cosmwasm-std = { version = "1.0.0" }
		cw-multi-test = { version = "0.13.4", optional = true }

feat: add multi test utils #29

feat: add multi test utils #29

Conversation

dadamu commented Jul 27, 2022

codecov bot commented Jul 27, 2022 • edited Loading

Codecov Report

dadamu Jul 28, 2022 • edited Loading

Choose a reason for hiding this comment

dadamu Jul 28, 2022

Choose a reason for hiding this comment

leobragaz commented Jul 28, 2022

manu0466 Jul 28, 2022

Choose a reason for hiding this comment

manu0466 Jul 28, 2022

Choose a reason for hiding this comment

manu0466 Jul 28, 2022

Choose a reason for hiding this comment

dadamu Jul 28, 2022 • edited Loading

Choose a reason for hiding this comment

dadamu Jul 28, 2022 • edited Loading

Choose a reason for hiding this comment

manu0466 Jul 29, 2022

Choose a reason for hiding this comment

dadamu Jul 29, 2022

Choose a reason for hiding this comment

manu0466 Jul 29, 2022

Choose a reason for hiding this comment

dadamu Jul 29, 2022 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jul 27, 2022 •

edited

Loading

dadamu Jul 28, 2022 •

edited

Loading

dadamu Jul 28, 2022 •

edited

Loading

dadamu Jul 28, 2022 •

edited

Loading

dadamu Jul 29, 2022 •

edited

Loading