-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve mocks lib #30
Conversation
Codecov Report
@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 90.94% 91.06% +0.11%
==========================================
Files 27 27
Lines 2276 2282 +6
==========================================
+ Hits 2070 2078 +8
+ Misses 206 204 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goot me! Nice work 🚀
What do you think of removing the mocks
feature and build the mocks just when the target is not wasm32
?
I see at the moment that the mocks
module is compiled only when the mocks
feature is enabled and not compiling for wasm32
I think we can safely remove the mocks
feature.
@manu0466 Great thought, that makes more sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
This PR merges
test_utils
andmocks
into a folder, then renaming tomack_apps
andmock_queriers
.Besides, it also improves
x/posts
andx/reports
to haveMockQueries
struct collecting all mock functions as other modules.