Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject DTag transfers #297

Closed
RiccardoM opened this issue Oct 14, 2020 · 1 comment · Fixed by #305
Closed

Reject DTag transfers #297

RiccardoM opened this issue Oct 14, 2020 · 1 comment · Fixed by #305
Assignees
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/profiles Module that allows to create and manage decentralized social profiles
Milestone

Comments

@RiccardoM
Copy link
Contributor

Feature description

Currently, during the DTag transferring process, there is no way for a user to reject a DTag request. This, together with the fact that trades are kept "suspended" if the sending user's DTag changes, can cause strange situations.

Let's consider the situation in which Alice has DTag first and Bob wants it. Then this happens:

  1. Bob sends a request to Alice for her DTag.
  2. Alice changes her DTag to second.

In this case the following would occur:

  1. The initial Bob's request cannot be accepted anymore since Alice has changed her DTag.
  2. Bob cannot send a new DTag request to Alice since the request is already opened.
  3. Bob cannot delete the initial request to open a new one.

Implementation proposal

In order to solve this problem, I think we should implement the following processes:

  1. If Alice's DTag changes, all the requests made towards her should be deleted.
  2. Once that Alice accepts a DTag request, all requests made towards her should be deleted.

Also, we should implement two new message types:

  1. MsgCancelDTagRequest
    This can be used only by the user who started the request, and it cancels the process by deleting the request itself.
  2. MsgRejectDTagRequest
    This can be used only by the user who is asked for their DTag. This also cancels the process.
@RiccardoM RiccardoM added the kind/new-feature Propose the addition of a new feature that does not yet exist label Oct 14, 2020
@RiccardoM RiccardoM added the x/profiles Module that allows to create and manage decentralized social profiles label Oct 14, 2020
@RiccardoM RiccardoM added this to the v0.13.0 milestone Oct 15, 2020
@leobragaz
Copy link
Contributor

leobragaz commented Oct 15, 2020

@RiccardoM The 1st and 2nd point of the implementation proposal are already implemented.
For everything else I'll start right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/new-feature Propose the addition of a new feature that does not yet exist x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants