Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of json inside genesis-related commands #348

Closed
RiccardoM opened this issue Jan 19, 2021 · 0 comments · Fixed by #347
Closed

Remove the usage of json inside genesis-related commands #348

RiccardoM opened this issue Jan 19, 2021 · 0 comments · Fixed by #347
Assignees
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Milestone

Comments

@RiccardoM
Copy link
Contributor

Context

Currently we're using a lot of json.Marshal and json.Unmarshal inside genesis-related methods (eg. DefaultGenesis, VerifyGenesis and InitGenesis). This is done due to cosmos/cosmos-sdk#8333.

Although it works, it makes it incredibly hard to manage things, as we need to always remember what to use (json vs cdc).

Implementation proposal

I think we should remove all the gogoproto.jsontag usage from our Proto file definitions, and revert to using only cdc instead. This would make it easier and simplify a lot of things in the future.

@RiccardoM RiccardoM added the kind/enhancement Enhance an already existing feature; no "New feature" to add label Jan 19, 2021
@RiccardoM RiccardoM self-assigned this Jan 19, 2021
@RiccardoM RiccardoM added this to the v0.15.1 milestone Jan 19, 2021
@RiccardoM RiccardoM mentioned this issue Jan 20, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhance an already existing feature; no "New feature" to add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant