-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how post are responded #498
Labels
Milestone
Comments
dadamu
added
kind/enhancement
Enhance an already existing feature; no "New feature" to add
x/posts
Post module
labels
Jun 18, 2021
I think we can simply delete all the different things that are not the message QueryPostResponse {
desmos.posts.v1beta1.Post post = 1;
} NotesIf not already present, we should add the following queries: |
This was referenced Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature description
In current version, the post response returns whole content includes all the
PostReactions
andUserAnswers
. In my opinion, both of them inPostResponse
could be replaced with the total count. As a result, the post response will be much smaller and much more fast when querying. Then,PostReactions
can also be paginated when querying whole reactions of the post.Implementation proposal
Change the post response struct, say:
Thoughts on it? @RiccardoM @bragaz
The text was updated successfully, but these errors were encountered: