-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make profiles query user parameter optional #534
Comments
This sounds good to me 👍 , plus it can be done easily now with all the paginated requests |
It sounds good to me, too. 👍 |
@dadamu maybe it's a good idea |
I think we can avoid doing this. Developers will use the |
From my experience, most issue due to large return result is from gRPC gateway. At least CLI can handle it but just like what @RiccardoM mentioned the user just has to wait. |
Context
Currently when querying the
x/profiles
module data, almost all queries require to specify a single user to which to query the data for. Examples:query blocks [user]
query relationships [user]
query incoming-dtag-transfer-requests [user]
While this is surely handy, I think we should allow developers to also query for all such data without specifying a single user.
Proposal
My proposal is to make the
[user]
parameter optional on all queries, allowing to get all the stored data with pagination:query blocks [[user]]
query relationships [[user]]
query dtag-transfer-requests
Note. This command should be a different one from the
incoming-dtag-transfer-requests
to avoid any confusionPlease let me know what you guys think @bragaz @dadamu
The text was updated successfully, but these errors were encountered: