-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Client App] Can't install for Brave on Linux #116
Comments
@PoorPocketsMcNewHold, thanks for the detailed bug report, and for sharing a workaround! |
Just to clarify, Buster can be installed on Brave, and does work perfectly (Despite all the previous issues with it since). It just that the Brave Client installer doesn't detect the correct folder to install itself, on the Brave browser. |
Little precision, I’ve changed my distribution, to OpenSUSE, and during the install of the buster client, it did make the assumption that it was Google Chrome, despite the following google-chrome folder not being existent on this distribution. |
There is no good way for the browser extension to detect that it is running in Brave, because Brave does not support the runtime.getBrowserInfo API, and the user agent is taken from Chrome. Brave currently reads Chrome's native messaging registry key on Windows, and they check Chrome's native messaging manifest on macOS. Brave should either do the same on Linux, or give extensions a way to detect the browser they're running in. I'd suggest to open a bug report for this on the Brave issue tracker. |
To summarize, the workaround to install the client app for Brave on Linux is to copy or move the manifest file created by the client app installer for Chrome. After the installer shows an error, run this command from your terminal: cp ~/.config/google-chrome/NativeMessagingHosts/org.buster.client.json ~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts/ |
System
Extension
buster-client-setup-v0.2.0-linux-amd64
* Extension version: [e.g. 1.0.0]* User input simulation: [e.g. yes, no]* Client app version: [e.g. 1.0.0]* Client app installed successfully: [e.g. yes, no]Bug description
The client app seems to not being able to distinguish between Brave browser and chromium, suggesting by default to install in what would be the chromium install directory (Which is inexistant btw)
Logs
Browser: Brave Browser Beta 0.70.104
A way to fix this, outside of making the client app able distinguish between the two, is to replace the Chromium directory, to this following one :
/home/USER/.config/BraveSoftware/Brave-Browser(Or add ¨-Beta¨ or ¨-Nightly¨)/NativeMessagingHosts
The text was updated successfully, but these errors were encountered: