Add tests for private, indexer and set-only properties (#102)

Author: sungam3r

src/Destructurama.Attributed.Tests/AttributedDestructuringTests.cs

@@ -15,13 +15,45 @@ public void Throwing_Accessor_Should_Be_Handled()
 
         var evt = DelegatingSink.Execute(customized);
 
-        // Verify
         var sv = (StructureValue)evt.Properties["Customized"];
         sv.Properties.Count.ShouldBe(1);
         sv.Properties[0].Name.ShouldBe("BadProperty");
         sv.Properties[0].Value.ShouldBeOfType<ScalarValue>().Value.ShouldBe("***");
     }
 
+    [Test]
+    public void Only_Settable_Accessor_Should_Be_Handled()
+    {
+        var customized = new ClassWithOnlySetters();
+
+        var evt = DelegatingSink.Execute(customized);
+
+        var sv = (StructureValue)evt.Properties["Customized"];
+        sv.Properties.Count.ShouldBe(0);
+    }
+
+    [Test]
+    public void Private_Property_Should_Be_Handled()
+    {
+        var customized = new ClassWithPrivateProperty();
+
+        var evt = DelegatingSink.Execute(customized);
+
+        var sv = (StructureValue)evt.Properties["Customized"];
+        sv.Properties.Count.ShouldBe(0);
+    }
+
+    [Test]
+    public void Indexer_Should_Be_Handled()
+    {
+        var customized = new ClassWithIndexer();
+
+        var evt = DelegatingSink.Execute(customized);
+
+        var sv = (StructureValue)evt.Properties["Customized"];
+        sv.Properties.Count.ShouldBe(0);
+    }
+
     [Test]
     public void AttributesAreConsultedWhenDestructuring()
     {
@@ -63,6 +95,31 @@ public class ClassWithThrowingAccessor
         public string? BadProperty => throw new FormatException("oops");
     }
 
+    public class ClassWithOnlySetters
+    {
+        [LogMasked]
+        public string? Name { set { } }
+
+        [LogAsScalar]
+        public Struct1 Struct1 { set { } }
+    }
+
+    public class ClassWithPrivateProperty
+    {
+        [LogMasked]
+        private string? Name { get; set; } = "Tom";
+    }
+
+    public class ClassWithIndexer
+    {
+        [LogMasked]
+        public string? this[int index]
+        {
+            get => "Tom";
+            set { }
+        }
+    }
+
     [LogAsScalar]
     public class ImmutableScalar
     {

src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs

@@ -47,13 +47,32 @@ public bool TryDestructure(object value, ILogEventPropertyValueFactory propertyV
         return cached.CanDestructure;
     }
 
+    private static IEnumerable<PropertyInfo> GetPropertiesRecursive(Type type)
+    {
+        var seenNames = new HashSet<string>();
+
+        while (type != typeof(object))
+        {
+            var unseenProperties = type.GetProperties(BindingFlags.Public | BindingFlags.Instance | BindingFlags.DeclaredOnly)
+                .Where(p => p.CanRead && p.GetMethod.IsPublic && p.GetIndexParameters().Length == 0 && !seenNames.Contains(p.Name));
+
+            foreach (var propertyInfo in unseenProperties)
+            {
+                seenNames.Add(propertyInfo.Name);
+                yield return propertyInfo;
+            }
+
+            type = type.BaseType;
+        }
+    }
+
     private CacheEntry CreateCacheEntry(Type type)
     {
         var classDestructurer = type.GetCustomAttribute<ITypeDestructuringAttribute>();
         if (classDestructurer != null)
             return new(classDestructurer.CreateLogEventPropertyValue);
 
-        var properties = type.GetPropertiesRecursive().ToList();
+        var properties = GetPropertiesRecursive(type).ToList();
         if (!_options.IgnoreNullProperties && properties.All(pi =>
             pi.GetCustomAttribute<IPropertyDestructuringAttribute>() == null
             && pi.GetCustomAttribute<IPropertyOptionalIgnoreAttribute>() == null))