Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lattice pruning broken by vectorization #250

Closed
Hespe opened this issue Sep 12, 2024 · 0 comments · Fixed by #258
Closed

Lattice pruning broken by vectorization #250

Hespe opened this issue Sep 12, 2024 · 0 comments · Fixed by #258
Labels
bug Something isn't working

Comments

@Hespe
Copy link
Member

Hespe commented Sep 12, 2024

Due to the vectorization of element.length, some of the pruning functions implemented for Segment currently fail for vectorized lattices. I've encountered this issue for without_inactive_zero_length_elements, resulting in a crash at

cheetah/cheetah/accelerator/segment.py

Line 173 in 440850f

if element.length > 0.0
In addition, I suspect inactive_elements_as_drifts fails for the same reason.
@Hespe Hespe mentioned this issue Sep 12, 2024
Closed
7 tasks
@Hespe Hespe added the bug Something isn't working label Sep 12, 2024
@Hespe Hespe mentioned this issue Sep 24, 2024
Merged
14 tasks
@Hespe Hespe linked a pull request Sep 24, 2024 that will close this issue
Fix lattice pruning for vectorized segments #258
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix lattice pruning for vectorized segments Hespe/cheetah
1 participant
@Hespe