Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated property in Beam class #279

Closed
Hespe opened this issue Oct 17, 2024 · 1 comment · Fixed by #284
Closed

Outdated property in Beam class #279

Hespe opened this issue Oct 17, 2024 · 1 comment · Fixed by #284
Labels
bug Something isn't working

Comments

@Hespe
Copy link
Member

Hespe commented Oct 17, 2024

In the Beam class, there still exists a stub for the property mu_s, which has been replaced by mu_tau in ParameterBeam and ParticleBeam.

cheetah/cheetah/particles/beam.py

Lines 266 to 268 in 72baff6

@property
def mu_s(self) -> torch.Tensor:
raise NotImplementedError

@Hespe Hespe added the bug Something isn't working label Oct 17, 2024
@Hespe
Copy link
Member Author

Hespe commented Oct 21, 2024

See also #238

@Hespe Hespe mentioned this issue Oct 22, 2024
Merged
14 tasks
@Hespe Hespe linked a pull request Oct 22, 2024 that will close this issue
Improve Beam docstrings and type hints #284
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Beam docstrings and type hints Hespe/cheetah
1 participant
@Hespe