Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Species should probably be nn.Module #369

Open
jank324 opened this issue Mar 7, 2025 · 1 comment
Open

Species should probably be nn.Module #369

jank324 opened this issue Mar 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@jank324
Copy link
Member

jank324 commented Mar 7, 2025

No description provided.

@jank324 jank324 added the bug Something isn't working label Mar 7, 2025
@cr-xu
Copy link
Member

cr-xu commented Mar 12, 2025

As we don't intend to perform any calculations directly on the Species class, I don't immediately see the benefit of making it a nn.Module. What's your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cr-xu @jank324