-
-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing extension point: treeCopyHandler in container {}
while using autoCorrect.
#6666
Comments
Missing extension point: org.jetbrains.kotlin.com.intellij.treeCopyHandler in container {}
while using autoCorrect.Missing extension point: treeCopyHandler in container {}
while using autoCorrect.
Which tests are you referring to? The one on |
No, my tests :) i.e. the one that's in the Repro. It works on 1.23.4 but not on current main. I think I've simplified it enough that it could be part of the detekt test suite. |
Support for the extension was removed from ktlint as apparently it was removed from Kotlin from 1.9. There's more info on pinterest/ktlint#2044. It was removed from detekt as well in a different PR. I don't think this is something we can do much about and the rules will need to be adjusted to avoid hitting methods that require the extension to be supported. More info on that is in the linked issue. |
Ah, nice, so I see this is just straight up removed in #6255. |
I wonder if we should provide a ruleauthors rule that flags affected methods (even if the list is non-exhaustive), because all of those methods look like normal public API, they just break at runtime. This could even help ktlint rule authors (if they have detekt set up on the project). |
It's a thought, however autocorrect isn't something we really support at all outside of the ktlint wrapper so I think it would be better as a third party rule personally. I'll close this issue though as it's something that we won't/can't fix in detekt. |
If anyone needs it, here how I resolve this exception: TWiStErRob/net.twisterrob.detekt@389baa8 |
Expected Behavior
Test passes as before on 1.23.4.
Observed Behavior
java.lang.IllegalArgumentException: Missing extension point: org.jetbrains.kotlin.com.intellij.treeCopyHandler in container {}
(click for full stack trace)Steps to Reproduce
I minimized this from my real problem branch.
Context
This has been fixed once by @cortinico related to ktlint: #4545, but now I have a repro without, just directly use Detekt APIs. I do not understand this error at all :) I hope the fix won't be as evil as the number of this issue.
Potential red herring
There was a recent change while updating Kotlin detekt/Kotlin to latest, which might be relevant here:
I say red herring, because even with the old deprecated version it's failing. However I might be using the wrong API to generate replacement.
Your Environment
--scan
option when running the gradle task): N/Areturns modified code when rule supports autoCorrect
.The text was updated successfully, but these errors were encountered: