Fix headup hole lookup (#267) (#268)

zear · web-flow · commit 1531f4a9d6d1 · 2022-12-11T14:44:38.000-08:00
When searching for a particular headup slot, don't return on the first
empty hole, but rather try to find if the matching slot is in use.

This resolves a bug where two headups of the same type could end up
displayed on top of each other.

Signed-off-by: Artur Rojek &lt;contact@artur-rojek.eu&gt;
diff --git a/src/DETHRACE/common/displays.c b/src/DETHRACE/common/displays.c
@@ -618,7 +618,6 @@ int FindAHeadupHoleWoofBarkSoundsABitRude(int pSlot_index) {
         }
         if (the_headup->type == eHeadup_unused) {
             empty_one = i;
-            break;
         }
     }
     return empty_one;

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,6 @@ int FindAHeadupHoleWoofBarkSoundsABitRude(int pSlot_index) {`
`618`	`618`	`}`
`619`	`619`	`if (the_headup->type == eHeadup_unused) {`
`620`	`620`	`empty_one = i;`
`621`		`- break;`
`622`	`621`	`}`
`623`	`622`	`}`
`624`	`623`	`return empty_one;`