Use BRender macro's + floats + move around code blocks (#250)

Author: madebr

src/DETHRACE/common/car.c

@@ -3534,7 +3534,7 @@ int RestoreOptions() {
         LOG_WARN("Failed to open OPTIONS.TXT");
         return 0;
     }
-    while (fgets(line, 80, f)) {
+    while (fgets(line, COUNT_OF(line), f)) {
         if (sscanf(line, "%79s%f", token, &arg) == 2) {
             if (!strcmp(token, "YonFactor")) {
                 SetYonFactor(arg);

src/DETHRACE/common/finteray.c

@@ -142,29 +142,17 @@ void InitSkids() {
     for (skid = 0; skid < COUNT_OF(gSkids); skid++) {
         gSkids[skid].actor = BrActorAllocate(BR_ACTOR_MODEL, NULL);
         BrActorAdd(gNon_track_actor, gSkids[skid].actor);
-        gSkids[skid].actor->t.t.mat.m[1][1] = 0.0099999998;
+        gSkids[skid].actor->t.t.mat.m[1][1] = 0.01f;
         gSkids[skid].actor->render_style = BR_RSTYLE_NONE;
         square = BrModelAllocate(NULL, 4, 2);
-        square->vertices[0].p.v[0] = -0.5;
-        square->vertices[0].p.v[1] = 1.0;
-        square->vertices[0].p.v[2] = -0.5;
-        square->vertices[1].p.v[0] = -0.5;
-        square->vertices[1].p.v[1] = 1.0;
-        square->vertices[1].p.v[2] = 0.5;
-        square->vertices[2].p.v[0] = 0.5;
-        square->vertices[2].p.v[1] = 1.0;
-        square->vertices[2].p.v[2] = 0.5;
-        square->vertices[3].p.v[0] = 0.5;
-        square->vertices[3].p.v[1] = 1.0;
-        square->vertices[3].p.v[2] = -0.5;
-        square->vertices[0].map.v[0] = 0.0;
-        square->vertices[0].map.v[1] = 0.0;
-        square->vertices[1].map.v[0] = 0.0;
-        square->vertices[1].map.v[1] = 1.0;
-        square->vertices[2].map.v[0] = 1.0;
-        square->vertices[2].map.v[1] = 1.0;
-        square->vertices[3].map.v[0] = 1.0;
-        square->vertices[3].map.v[1] = 0.0;
+        BrVector3Set(&square->vertices[0].p, -0.5f, 1.0f, -0.5f);
+        BrVector3Set(&square->vertices[1].p, -0.5f, 1.0f, 0.5f);
+        BrVector3Set(&square->vertices[2].p, 0.5f, 1.0f, 0.5f);
+        BrVector3Set(&square->vertices[3].p, 0.5f, 1.0f, -0.5f);
+        BrVector2Set(&square->vertices[0].map, 0.0f, 0.0f);
+        BrVector2Set(&square->vertices[1].map, 0.0f, 1.0f);
+        BrVector2Set(&square->vertices[2].map, 1.0f, 1.0f);
+        BrVector2Set(&square->vertices[3].map, 1.0f, 0.0f);
         square->faces[0].vertices[0] = 0;
         square->faces[0].vertices[1] = 1;
         square->faces[0].vertices[2] = 2;

src/DETHRACE/common/loading.c

@@ -837,7 +837,7 @@ void DrMatrix34Rotate(br_matrix34* mat, br_angle r, br_vector3* a) {
 
     s = FastScalarSinAngle(r);
     c = FastScalarCosAngle(r);
-    t = 1.0 - c;
+    t = 1.0f - c;
     txy = t * a->v[0] * a->v[1];
     txz = t * a->v[0] * a->v[2];
     tyz = t * a->v[1] * a->v[2];
@@ -1316,8 +1316,8 @@ void CreatePuffOfSmoke(br_vector3* pos, br_vector3* v, br_scalar strength, br_sc
 
     BrVector3InvScale(&gSmoke[gSmoke_num].v, v, WORLD_SCALE);
     gSmoke[gSmoke_num].v.v[1] += (1.0f / WORLD_SCALE);
-    gSmoke[gSmoke_num].pos = *pos;
-    gSmoke[gSmoke_num].radius = 0.05;
+    BrVector3Copy(&gSmoke[gSmoke_num].pos, pos);
+    gSmoke[gSmoke_num].radius = 0.05f;
     if ((pType & 0xF) == 7) {
         gSmoke[gSmoke_num].radius *= 2.0f;
     } else {

src/DETHRACE/common/skidmark.c

@@ -118,7 +118,7 @@ void RaceCompleted(tRace_over_reason pReason) {
         default:
             break;
         }
-        if (gNet_mode) {
+        if (gNet_mode != eNet_mode_none) {
             gRace_finished = 8000;
         } else {
             gRace_finished = 4000;

src/DETHRACE/common/spark.c

@@ -612,7 +612,7 @@ tS3_sound_source* S3CreateSoundSourceBR(br_vector3* pPosition, br_vector3* pVelo
         return 0;
     }
     source = S3CreateSoundSource(pPosition, pVelocity, pBound_outlet);
-    if (source) {
+    if (source != NULL) {
         source->brender_vector = 1;
     }
     return source;