Don't leak file descriptors in GetFileAttributesA polyfill (#372)

madebr · web-flow · commit a74ee0ac8271 · 2024-06-20T10:22:34.000+12:00
diff --git a/src/harness/win95/polyfill.c b/src/harness/win95/polyfill.c
@@ -26,9 +26,10 @@
 uint32_t GetFileAttributesA_(char* lpFileName) {
 
     FILE* f = fopen(lpFileName, "r");
-    if (!f) {
+    if (f == NULL) {
         return INVALID_FILE_ATTRIBUTES;
     }
+    fclose(f);
     return FILE_ATTRIBUTE_NORMAL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,10 @@`
`26`	`26`	`uint32_t GetFileAttributesA_(char* lpFileName) {`
`27`	`27`
`28`	`28`	`FILE* f = fopen(lpFileName, "r");`
`29`		`- if (!f) {`
	`29`	`+ if (f == NULL) {`
`30`	`30`	`return INVALID_FILE_ATTRIBUTES;`
`31`	`31`	`}`
	`32`	`+ fclose(f);`
`32`	`33`	`return FILE_ATTRIBUTE_NORMAL;`
`33`	`34`	`}`
`34`	`35`