-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should CI test with CMake 2.8.12? #234
Comments
@robertodr I don't know the answer. I think we should define the supported CMake range and test the lower bound or both bounds. I also think that some stuff will fail on 2.8.12 since this was the motivation to curl the pre-compiled CMake. But independently of failing tests we should do the "right thing". Not sure what it is. |
I would make the issue more general: since autocmake is heavy cmake dependent, autocmake must know cmake version and deal with it, when necessary - for example, if some tests are not running with a "very old" cmake. |
The thing is that there is Autocmake (the Python code and some core CMake stuff) and there are modules. We test them and version them (kind-of) together. So I am not sure. |
We can let the testing discover the CMake version and skip some tests which test modules which require a higher CMake version. |
Quoting from #231 231:
"A question: since Autocmake is CMake-version agnostic, shouldn't the tests be run using the oldest supported version aka 2.8.12?"
The text was updated successfully, but these errors were encountered: