Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should CI test with CMake 2.8.12? #234

Open
bast opened this issue Mar 7, 2018 · 4 comments
Open

Should CI test with CMake 2.8.12? #234

bast opened this issue Mar 7, 2018 · 4 comments

Comments

@bast
Copy link
Member

bast commented Mar 7, 2018

Quoting from #231 231:
"A question: since Autocmake is CMake-version agnostic, shouldn't the tests be run using the oldest supported version aka 2.8.12?"

@bast
Copy link
Member Author

bast commented Mar 7, 2018

@robertodr I don't know the answer. I think we should define the supported CMake range and test the lower bound or both bounds. I also think that some stuff will fail on 2.8.12 since this was the motivation to curl the pre-compiled CMake. But independently of failing tests we should do the "right thing". Not sure what it is.

@miroi
Copy link
Contributor

miroi commented Mar 7, 2018

I would make the issue more general: since autocmake is heavy cmake dependent, autocmake must know cmake version and deal with it, when necessary - for example, if some tests are not running with a "very old" cmake.

@bast
Copy link
Member Author

bast commented Mar 7, 2018

The thing is that there is Autocmake (the Python code and some core CMake stuff) and there are modules. We test them and version them (kind-of) together. So I am not sure.

@bast
Copy link
Member Author

bast commented Mar 7, 2018

We can let the testing discover the CMake version and skip some tests which test modules which require a higher CMake version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants