Can't delete tags with "#" (number sign) on it

[AnimMouse]

I can't delete tags using this, I got this error:

Run dev-drprasad/delete-older-releases@v0.2.0
  with:
    keep_latest: 1
    delete_tags: true
    delete_tag_pattern: a
  env:
    GITHUB_TOKEN: ***
💬  no `repo` name given. fall-ing back to this repo
🔖  corresponding tags also will be deleted
releases containing a will be targeted
💬  found total of 2 matching active release(s)
🍻  found 1 older release(s)
starting to delete a#8 with id 39024378
🌶  failed to delete tag "a#8"  <- Reference does not exist

[dev-drprasad]

Message implying that there is no tag exists with name "a#8". Can you cross whether that tag exists ? Ping me repo url if it is public, I will also check

[AnimMouse]

https://github.com/AnimMouse/ffmpeg-autobuild-gpl/releases/tag/a%238

[AnimMouse]

The release was deleted, but the tag is not. Tested again on https://github.com/AnimMouse/ffmpeg-autobuild-gpl/runs/2260494888

[dev-drprasad]

If you don't mind can you release tag without "#" in it and delete it using this action. I just want to make sure "#" in tag is not the problem

[AnimMouse]

Tried tags without "#" and it works, it seems like the "#" is the problem.

Run dev-drprasad/delete-older-releases@v0.2.0
💬  no `repo` name given. fall-ing back to this repo
🔖  corresponding tags also will be deleted
releases containing a will be targeted
💬  found total of 3 matching active release(s)
🍻  found 2 older release(s)
starting to delete a2 with id 40909959
starting to delete a1 with id 40909957
👍🏼  2 older release(s) deleted successfully!

[thadguidry]

@AnimMouse we have a potential fix for this in #11 which would change to using regex for the delete_tag_pattern option. Do you think that might help your situation? Do you have strong feelings about my comment in that PR one way or another?

[AnimMouse]

Yes, using regex is much better.

[yoomlam]

+1 on using regex

[thadguidry]

Fixed in PR #30 and new release https://github.com/dev-drprasad/delete-older-releases/releases/tag/v0.3.1