Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create release workflow #156

Closed
micheelengronne opened this issue May 11, 2020 · 7 comments
Closed

Create release workflow #156

micheelengronne opened this issue May 11, 2020 · 7 comments
Assignees

Comments

@micheelengronne
Copy link
Member

micheelengronne commented May 11, 2020

Is your feature request related to a problem? Please describe.
Create an automated release workflow.

Based on https://github.com/dev-sec/ansible-nginx-hardening/pull/28/files

We must add the inspec.yml version field update.

Internally, I use mikefarah/yq with the following cli:

yq w -I4 -i inspec.yml version ${nextRelease.version} && sed -i '1i---' inspec.yml

The sed is needed as yq removes the leading --- yq issue

What are your thoughts on that @rndmh3ro ?

This was referenced May 11, 2020
@chris-rock
Copy link
Member

I like that, should we tie this to Github actions?

@micheelengronne
Copy link
Member Author

I think so. I would reproduce the 2 files present in the ansible-nginx-hardening commit.

The only thing that's missing is the step to update inspec.yml. I have never done a github actions before (I work on Gitlab and Gitea) so I don't know the correct syntax of this step.

@rndmh3ro
Copy link
Member

@micheelengronne
Copy link
Member Author

I see there is no push action in your release.yml. Does the create-release action make the push or should I include one to push the new inspec.yml before the create-release ?

@rndmh3ro
Copy link
Member

Yeah, my release-action does not push. the changelog-action does it.

should I include one to push the new inspec.yml before the create-release ?

If you need to update the version, then yes, I think it should be done there.

@micheelengronne
Copy link
Member Author

Ok, I will do a first draft.

@micheelengronne
Copy link
Member Author

#157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants