Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't access subscribe page on Brave/mobile #14

Open
marcelkornblum opened this issue May 12, 2019 · 8 comments
Open

Can't access subscribe page on Brave/mobile #14

marcelkornblum opened this issue May 12, 2019 · 8 comments

Comments

@marcelkornblum
Copy link

Am using brave (powered by chrome) on Pixel 2/Android Q.
Tapping subscribe link doesn't do anything, opening it in a new page results in a GitHub branded 404 page.
This is after GitHub login process appeared to complete successfully (hard to tell as site state didn't update after callback)

@marcelkornblum
Copy link
Author

I think this is related to the signin not working - I go through the GH screens (and they now flash past as I've already authed the app) but the originating site doesn't update - also on my Chrome/Win desktop. I asked a colleague to try (it's a genuine recommendation to the group) and his browser updated after signin to show a logout link.

@nuno-barreiro
Copy link
Contributor

I think the trouble you're having is related to the Brave Shields. If you notice there is some content being blocked when you try to sign in with the GH account. If you disable brave shields for DevCon website you should be fine.

@marcelkornblum
Copy link
Author

Yeah I tried that. Same was true on my windows Chrome, so I think it must be something else - unless I managed to get it into a state on mobile that it couldn't rescue itself from even when I was on desktop later. I finally worked around it, I think using Safari on mac...

@grudelsud
Copy link
Member

hey @marcelkornblum we have found and fixed a bug in #59 that might have caused this problem. Would it be possible for you to check again? I've just tested with my Chrome on Android and it seems to work fine. Would be good to know if we can close this bug.

@silviopaganini
Copy link
Member

is this closed now? @marcelkornblum

@marcelkornblum
Copy link
Author

Just tried on brave and I think this bug is fixed but the flow is still broken. From a GitHub unauthed session on Android/brave the login pop up appears and disappears immediately. I can now access the subscribe page which just has a toaster message telling me I need to sign in.

@grudelsud
Copy link
Member

I think someone else mentioned this issue on brave as well. Bloody developers always using obscure browsers... 😂

@grudelsud grudelsud changed the title Can't access subscribe page on mobile Can't access subscribe page on Brave/mobile Feb 14, 2020
@marcelkornblum
Copy link
Author

It's still the Android Chrome under the hood I believe ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants